Stub DNS in notification delivery tests#2838
Open
robzolkos wants to merge 4 commits intobasecamp:mainfrom
Open
Stub DNS in notification delivery tests#2838robzolkos wants to merge 4 commits intobasecamp:mainfrom
robzolkos wants to merge 4 commits intobasecamp:mainfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Makes NotificationDeliveryTest deterministic by stubbing DNS resolution before creating the FCM push subscription, avoiding flaky CI failures under SSRF validation.
Changes:
- Added a public test IP constant to the integration test.
- Stubbed DNS resolution during test setup before creating the push subscription.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
flavorjones
requested changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotificationDeliveryTestcreates a push subscription forfcm.googleapis.combut was relying on live DNS resolution during the test. That makes the test nondeterministic under the SSRF validation added toPush::Subscription, and it recently failed in CI here: https://github.com/basecamp/fizzy/actions/runs/24322726747/job/71011847248. This change makes the test deterministic by stubbing DNS to a known public IP, which matches the existing project pattern for push-subscription tests and prevents unrelated PRs from tripping this flaky setup.Changes
NotificationDeliveryTeststub_dns_resolution(...)before creating the test push subscriptionNotes